[Webkit-unassigned] [Bug 30144] MIPS JIT Supports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30144





--- Comment #13 from Gabor Loki <loki at inf.u-szeged.hu>  2009-10-08 00:18:05 PDT ---
(In reply to comment #10)
> > > +		    fprintf (stderr, "Error: Cannot create MIPS jump (J) due to the top four bits are different.\n");
> > > +		}
> > > +		*insn = 0x08000000 | ((new_target_address >> 2) & 0x3ffffff);
> > > +	    }
> > 
> > What happens if a jump cannot be created? Crash?
> 
>   Yes, if we cannot use "J", it will crash.
> But this type of jump can cover a 28-bit range of targets.  From running
> sunspider and v8 tests, 28-bit jumps seem ok.

The JavaScriptCore tests are essential. Did you test with
./WebKitTools/Scripts/run-javascriptcore-tests?

In additional, you should test at least with
./WebKitTools/Scripts/run-webkit-tests LayoutTests/fast/js as well! The new JS
regression tests were landed there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.