[Webkit-unassigned] [Bug 30188] REGRESSION(r49203): Text Drag and Drop stopped working in latest nightly build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30188


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40852|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #16 from Eric Seidel <eric at webkit.org>  2009-10-07 22:59:30 PDT ---
(From update of attachment 40852)
The empty comment line is not needed:
 654         //

I don't usually put < > around URLs.

I think this is OK to fix the bug, but I think we need to set this in a better,
clearer place. it's so strange that this is set here, instead of in some
earlier if.

Also, this code makes me wonder what other state we need to set for non-dhtml
drags?

And why shouldn't m_sourceDragOperation default to DragOperationAny and then
get set more restrictive in the DHTML case?  Again, this code is just ugly, and
poorly designed here.  Your argument over IRC that we should take this simple
fix and work to clean it up later is valid, but slightly saddening. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.