[Webkit-unassigned] [Bug 29909] [V8] Chromium's implementation of ScriptString is awful for XHR's responseText
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 18:59:19 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29909
Adam Barth <abarth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #40834|review? |review-
Flag| |
--- Comment #9 from Adam Barth <abarth at webkit.org> 2009-10-07 18:59:18 PDT ---
(From update of attachment 40834)
This looks great. Two minor syntactic issues:
1) There are a handful of style problems:
+}
+ScriptStringImpl::ScriptStringImpl(const String& s)
Missing a space between these two linds.
+ return v8ExternalScriptString(string);
Need four space indent here. (I think there was another indent problem too.)
2) ScriptStringImpl has nothing to do with v8 and should be in platform/text
somewhere. Maybe it should be called CachingStringBuilder ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list