[Webkit-unassigned] [Bug 30175] [Win] Windows DRT UIDelegate::doDragDrop does not return OLE drag-and-drop return value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30175


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40808|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2009-10-07 11:53:52 PDT ---
(From update of attachment 40808)
> +++ WebKit/win/WebCoreSupport/WebDragClient.cpp	(working copy)
> @@ -161,11 +161,9 @@ void WebDragClient::startDrag(DragImageR
>          if (SUCCEEDED(m_webView->uiDelegate(&ui))) {
>              COMPtr<IWebUIDelegatePrivate> uiPrivate;
>              if (SUCCEEDED(ui->QueryInterface(IID_IWebUIDelegatePrivate, (void**)&uiPrivate)))
> -                if (SUCCEEDED(uiPrivate->doDragDrop(m_webView, dataObject.get(), source.get(), okEffect, &effect)))
> -                    return;
> -        }
> -
> -        DoDragDrop(dataObject.get(), source.get(), okEffect, &effect);
> +                uiPrivate->doDragDrop(m_webView, dataObject.get(), source.get(), okEffect, &effect);
> +        } else
> +            DoDragDrop(dataObject.get(), source.get(), okEffect, &effect);

I don't think this change is what we want. This will require that all WebKit
clients that support the IWebUIDelegatePrivate interface implement doDragDrop.
I think we want to leave this code as it was.

> +++ WebKitTools/DumpRenderTree/win/EventSender.h	(working copy)
> @@ -29,13 +29,15 @@
>  #ifndef EventSender_h
>  #define EventSender_h
>  
> +#include <windows.h>

It would be nicer to just forward-declare HRESULT.

The rest of the DRT changes look fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.