[Webkit-unassigned] [Bug 29279] [Qt] Use RGB16 format for images on Symbian platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29279


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40138|review?                     |review-
               Flag|                            |




--- Comment #21 from Simon Hausmann <hausmann at webkit.org>  2009-10-07 08:14:20 PDT ---
(From update of attachment 40138)

>          LocalContentCanAccessRemoteUrls,
>          SessionStorageEnabled,
> -        DnsPrefetchEnabled
> +        DnsPrefetchEnabled,

The trailing comma shouldn't be there :)

>      };
>      enum WebGraphic {
>          MissingImageGraphic,
> @@ -134,6 +134,9 @@ public:
>  
>      static void enablePersistentStorage(const QString& path = QString());
>  
> +    void setImageFormat(QImage::Format format);
> +    QImage::Format imageFormat();
> +

If this is a regular member function of QWebSettings, then it must also be
possible to 
set the image format per-page. However in the implementation we can only use
QWebSettings::globalSettings(), we
do not have access to the page. Therefore if we decide to use this API, then we
it should be a static function in QWebSettings.


I am however concerned that we need such an API in the first place. Is there
any way we can make a smart
decision ourselves? Do we really have to bother the application programmer with
this?

And most importantly: Is this optimization still necessary after Holger's
changes from #27538 ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.