[Webkit-unassigned] [Bug 30144] MIPS JIT Supports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 6 18:52:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30144





--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2009-10-06 18:52:22 PDT ---
Two minor comments to start with, one of which will make it much easier to
review the patch:
1) We use four spaces for indentation rather than hard tabs.  The patch mixes
both spaces and tabs.  The mix of tabs and spaces in the patch makes the
indentation very hard to follow.  You can see this by clicking on the
“Formatted Diff” link above.
2) The copyright notice and license header should match the file that you based
your work on.  In particular the “All rights reserved.” statement has been
removed from the Apple copyright notice, and one file refers to "UNIVERSITY OF
SZEGED” but lacks the copyright notice which the reference implies should be
present.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list