[Webkit-unassigned] [Bug 30128] [v8] fix crbug/671: XPathEvaluator.evalute() will throw "NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30128





--- Comment #8 from anton muhin <antonm at chromium.org>  2009-10-06 14:10:50 PDT ---
(In reply to comment #7)
> This was already covered by fast/xpath/nsresolver-function.xhtml and many other
> tests. Did you see their results change when running the tests?

I didn't see any changes in LayoutTest results of both WebKit and Chromium. 
This nsresolver-function.xhtml apparently only tests Document.evaluate which
already had necessary logic.  I am aware of two cases this patch'd have fixed:
Document.createExpression and XPathEvaluator.evaluate.  Grepping through
fast/xpath doesn't show tests for createExpression.

> 
> Also, this is not a non-standard extension, see a note at the very bottom of
> <http://www.w3.org/TR/DOM-Level-3-XPath/ecma-script-binding.html>:
> 
> "Note: The parameter resolver of the method XPathEvaluator.evaluate is
> specified as an object that implements the XPathNSResolver interface.
> ECMAScript users can also pass to this method a function which returns a String
> and takes a String parameter instead of the resolver parameter."

Thank you very much for the pointer.  I wonder maybe we should alter
Document.idl then?  That would make logic in codegen somewhat less involved
(apparently)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.