[Webkit-unassigned] [Bug 29910] Load state can get out of sync in a client callback, leading to a crash.

Tue Oct 6 10:20:13 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29910

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40724|review?                     |review-
               Flag|                            |

--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-10-06 10:20:13 PDT ---
(From update of attachment 40724)
Even if this change is simple, we need to make sure we never have this bug
again.

Best would be to have a layout test.  If you really believe a layout test is
impossible, you need to explain so in the ChangeLog.  Explain why it's
impossible, and what would reproduce this if it were possible.  A
WebCore/manual-test is an option, but less desirable.

Additionally, you could/should  add a comment next to the
setState(FrameStateComplete), to explain why it needs to be set before
progressCompleted is called.

the loader is subtle.  We need to make it less subtle. :)  Your help in doing
so is most appreciated!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.