[Webkit-unassigned] [Bug 29653] [Qt] Qt-based browser fails to show the right language translation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29653





--- Comment #14 from Simon Hausmann <hausmann at webkit.org>  2009-10-06 08:14:36 PDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #10)
> > > uh, I dont really think that run-webkit-tests should depend on my current
> > > locale. Actually we hardcode things there (like render engine) so make it
> > > depend as little on the environment/system as possible, in order to make
> > > reliable expected test results.
> > 
> > The reason I have to change run-webkit-tests is:
> > In Qt Linux, QLocale depends on the environment variable LANG to figure out the
> > language of the system. While I run DumpRenderTree individually, the test case
> > passed as LANG is passed to the code. However, run-webkit-tests throws away
> > most of the env variables including LANG before, and the test case failed
> > because of that. As you suggested, I can hardcode the LANG here, e.g.,
> > en_US.iso88591 instead of taking the real one. What do you think? Thanks!
> 
> Yes, I believe hardcoding it would be better. Simon?

Sure. Either that or we simply make the tests expect the results from the
default (C) locale?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.