[Webkit-unassigned] [Bug 29279] [Qt] Use RGB16 format for images on Symbian platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29279





--- Comment #18 from Holger Freyther <zecke at selfish.org>  2009-10-06 07:36:01 PDT ---
(In reply to comment #16)
> (In reply to comment #14)

> I agree this is valid concern from design. However, the current
> WebCore/platform/qt code already includes code from WebKit/qt/*, see for
> example,
> WebCore/platform/graphics/qt/ImageQt.cpp:#include "qwebsettings.h". We can
> probably improve the code some time later.

Well, this is not a reason to do more harm.


> I totally agree. Fortunately, based on testing, the speed impact is much less
> while the memory reduction is significant. Note this patch only provides the
> API and implementation. It does not force the conversion by default.

The great thing is that we can measure this now and share results:
http://trac.webkit.org/wiki/QtWebKitPerformanceWork. If you are with Nokia I
can probably give you access to my existing test database. We can both look
into loading, cycling speed and memory usage.

Besides that the default depth should be handled by QImageReader and not in
WebCore and you need to rebase now as a major rework of the image handling was
just landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.