[Webkit-unassigned] [Bug 30128] [v8] fix crbug/671: XPathEvaluator.evalute() will throw "NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30128


anton muhin <antonm at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40718|                            |review?
               Flag|                            |




--- Comment #1 from anton muhin <antonm at chromium.org>  2009-10-06 07:03:43 PDT ---
Created an attachment (id=40718)
 --> (https://bugs.webkit.org/attachment.cgi?id=40718)
First pass

I am somewhat concerned how that complicates the logic of CodeGeneratorV8.pm. 
Another option I considered was to make necessary methods custom and provide
hand-written implementation.  However, that won't fix other methods that might
have the same problem, e.g., originally I only fixed Document.createExpression,
but fix propagated to XPathEvaluator.evaluate automatically.  On the other
hand, maybe we should decide for exceptions on case by case basis.  The last
thing that convinced me not to go with custom methods was Safari---they have
this special logic for all XPathEvaluators.

And another note.  I added new layout tests into existing .html, but if it's
against the rules (e.g. we'd like to emphasize that those tests verify contra
standard behaviour), I'd be glad to lift them into a separate file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.