[Webkit-unassigned] [Bug 26856] AnchorElement, ButtonElement, InputButton and Document should fire focus event when it is clicked.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26856


Chang Shu <Chang.Shu at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Chang.Shu at nokia.com




--- Comment #3 from Chang Shu <Chang.Shu at nokia.com>  2009-10-06 06:50:42 PDT ---
(In reply to comment #2)

Thanks for the review. I put some of my thoughts below.

> (From update of attachment 40659 [details])
> Although this patch gives the right behavior I think we need to be a bit
> careful here.
> 
> With this patch links gets the focus outline when the user clicks them. This is
> correct when it comes to CSS because we have something like :link:focus {
> outline: ...}. However, I doubt that we want this heavy visual clutter on links
> by default.

As it affects the click behavior not the hover behavior, the performance
degrade is probably ok. Other browsers, such as Firefox, also support this.

> 
> You can remove isMouseFocusable from HTMLAnchorElement now since all it does is
> call super.

Yes, will do.

> 
> Also, you need to include a layout test with your patch.

I will work on that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.