[Webkit-unassigned] [Bug 20081] [Qt] Add support for windowless NPAPI plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20081


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40627|review?                     |review-
               Flag|                            |




--- Comment #48 from Simon Hausmann <hausmann at webkit.org>  2009-10-06 03:29:17 PDT ---
(From update of attachment 40627)
There are a few coding style issues left and one detail:

> +
> +        No new tests. (OOPS!)

Please remove this line :)



> +                                   ((NPSetWindowCallbackStruct *)m_npWindow.ws_info)->depth);

Coding style :)


> +    const int drawableDepth = ((NPSetWindowCallbackStruct *)m_npWindow.ws_info)->depth;

Same here.


> +#ifndef QT_NO_XRENDER
> +    static const bool useXrender = qgetenv("QT_X11_NO_XRENDER").isNull(); // Should also check for XRender >= 0.5
> +#else
> +    static const bool useXrender = false;
> +#endif

Kenneth suggested on chat that this should perhaps be useXRender?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.