[Webkit-unassigned] [Bug 29518] [Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29518





--- Comment #5 from Jan Alonzo <jmalonzo at gmail.com>  2009-10-06 02:23:45 PDT ---
(In reply to comment #2)
> (From update of attachment 39816 [details])
> >+   PKG_CHECK_MODULES([SQLITE3],
> >+                     [sqlite3 >= $SQLITE_REQUIRED_VERSION],
> >+                     [sqlite3_has_pkg_config=yes],
> >+                     [sqlite3_has_pkg_config=no])
> >+   if test "$sqlite3_has_pkg_config" = "no"; then
> >+      AC_SEARCH_LIBS([sqlite3_open16], [sqlite3],
> >+                     [SQLITE3_LIBS="$LIBS";SQLITE3_CFLAGS="-I $srcdir/WebKitLibraries/WebCoreSQLite3"],
> >+                     [AC_MSG_ERROR([SQLite3 is required to enable Database support])])
> >+   fi
> 
> Silly question, shouldn't you first try to use the headers that might come with
> the library you just found with AC_SEARCH_LIBS?
> Or are you assuming that if there's no sqlite pkg-config file the only library
> you'll find is the one in WebKitLibraries?

Yes. If there's no .pc file or there's no pkg-config binary, I'll just use
what's in WebKitLibraries.

(In reply to comment #4)
> Did we ever get a report that someone wanted to use sqlite3 but didn't have
> pkg-config files?

Consider this a report.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.