[Webkit-unassigned] [Bug 30098] New: commit-queue can wrongly reject patches if the buildbots are behind

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 15:01:08 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30098

           Summary: commit-queue can wrongly reject patches if the
                    buildbots are behind
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org


commit-queue can wrongly reject patches if the buildbots are behind

The commit-queue uses the buildbot status to determine if it should be landing
patches or not.  Right now it checks before trying to build and if the bots are
green goes ahead and tries to land.  If the build/tests fail then it assumes
they were caused by the patch.

This can lead to false rejections if the bots are simply behind but they are
about to turn red. :(

There are many solutions we could use to fix this.  Two possibilities:
- roll out the patch locally and try to build/test again, if that passes
actually reject the patch.
- update to exactly the revision that the bots last tested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list