[Webkit-unassigned] [Bug 30033] [chromium] DateExtension has reliability bot crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30033


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40642|review?                     |review-
               Flag|                            |




--- Comment #6 from Adam Barth <abarth at webkit.org>  2009-10-05 10:57:53 PDT ---
(From update of attachment 40642)
We should add a test for the crash.

+ v8::Local<v8::Value> result =
V8Proxy::retrieve()->evaluate(WebCore::ScriptSourceCode("Date"), 0);

This seems overly complicated.  Why not just get the "Date" property of the
context's global object?

Other than those two issue, this looks reasonable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.