[Webkit-unassigned] [Bug 29867] [Qt] QWebPage autotest has three failures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29867


jedrzej.nowacki at nokia.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jedrzej.nowacki at nokia.com




--- Comment #6 from jedrzej.nowacki at nokia.com  2009-10-05 09:43:08 PDT ---
> Not a reviewer myself but as the author of the test here are some comments:
> 
> 1./ I'm not sure if there is a need to test interference between QWebPage
> settings instances. My intention was to test the interference on the JS engine
> level (as the JS engine is shared to some degree); that is that
> evaluateJavaScript() able to detect the presence/lack of the particular JS
> object. This of course only possible if there is a case where
> evaluateJavaScript() detects that the JS object is not present, which does not
> seems to be the case for App cache - which brings to my second point.

I suppose that testing interference between instances of JSC on QWebPage is
enough and it do the work.

> 2./ Layoutests only tests if App cache (when enabled) functions properly. If
> there is a setting to turn App cache off, than there is to be a
> definition/spec/test for the case when it is turned off. 
> 
> If the 
> 
> -QCOMPARE(testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled,
> "applicationCache", false), false);
> 
> test is removed than there is no behavior test for what happens if App Cache is
> turned off.
> 3./ In general JS should be able to detect if a particular JS API is enabled or
> not; this was also a goal of this test. The proposed patch does not
> demonstrates this.
> 

I agree it is bad.

> 
> This bug relates to a recent webkit-dev discussion -
> https://lists.webkit.org/pipermail/webkit-dev/2009-September/009982.html
> 

Thanks for link, it was really useful.
------------------------------------------------------------

Ok. First I will try to divide the test to simpler cases and than fight the
problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.