[Webkit-unassigned] [Bug 27546] [GTK] context menu overriding API is very limited

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27546





--- Comment #25 from Gustavo Noronha (kov) <gns at gnome.org>  2009-10-04 03:46:35 PDT ---
(From update of attachment 40181)
>  #endif
> +#if !PLATFORM(GTK)
>              appendItem(SearchWebItem);
>              appendItem(*separatorItem());
> -     
> +#endif

I think this makes sense, since we don't have an implementation for that, and I
don't see it happening in the near future.

>          if (!inPasswordField) {
> +#if PLATFORM(GTK)
> +            if (frame->editor()->canEditRichly()) {
> +                appendItem(*separatorItem());
> +                ContextMenuItem  FontMenuItem(SubmenuType, ContextMenuItemTagFontMenu, 
> +                    contextMenuItemTagFontMenu());
> +                createAndAppendFontSubMenu(m_hitTestResult, FontMenuItem);
> +                appendItem(FontMenuItem);
> +            }
> +#else


Conditionally displaying the font menu also sounds good, but I am not so sure
about the spelling check one. What you're saying is that this UI should be the
browser's responsibility, alone? I'd like to hear what Xan thinks here before
giving you r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.