[Webkit-unassigned] [Bug 30006] New: [MediaPlayer] Unnecessary checks for Messages types in callbacks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 01:54:32 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30006

           Summary: [MediaPlayer] Unnecessary checks for Messages types in
                    callbacks
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: slomo at circular-chaos.org


The EOS/StateChange/Error callbacks check the message type but they can only be
called with that exact message. The check should be removed ;)

Also instead of 3-4 different callbacks for all messages types it might make
sense to only use a single one, with a switch over the message types.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list