[Webkit-unassigned] [Bug 29717] [GTK] missing support for anamorphic PAR video size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29717





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2009-10-02 00:21:30 PDT ---
(In reply to comment #6)
> (From update of attachment 40435 [details])
> > @@ -178,14 +172,13 @@ webkit_video_sink_set_caps(GstBaseSink* bsink, GstCaps* caps)
> >      priv->width = width;
> >      priv->height = height;
> >  
> > -    /* We dont yet use fps or pixel aspect into but handy to have */
> > -    priv->fps_n = gst_value_get_fraction_numerator(fps);
> > -    priv->fps_d = gst_value_get_fraction_denominator(fps);
> > +    /* We dont yet use fps but handy to have */
> > +    if (!gst_structure_get_fraction(structure, "framerate",
> > +                                    &priv->fps_n, &priv->fps_d))
> > +        return FALSE;
> 
> So, I fail to see why we would return here, because failing to retrieve
> something we do not even use failed. Does this failing mean we will, say, fail
> to play the video? Returning here will only cause the pixel aspect ratio to not
> be set, in case we would be able to fetch it, but not this, so maybe just set a
> sane default, like you are doing for pixel aspect ratio.

As discussed on IRC with slomo :)

09:13:59 <     slomo> philn-tp: if there's no framerate something is really
broken and you shouldn't play the video
09:14:14 <  philn-tp> slomo: ok so the code is fine as it is?
09:14:18 <     slomo> philn-tp: even still images have a framerate (0/1)
09:14:21 < slomo> yes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.