[Webkit-unassigned] [Bug 29971] Clean up warnings in WebCore/bindings/v8/npruntime.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29971


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40457|review?                     |review-
               Flag|                            |




--- Comment #1 from David Levin <levin at chromium.org>  2009-10-01 21:16:31 PDT ---
(From update of attachment 40457)
minor change log fixes suggested.

> Index: WebCore/ChangeLog
> +2009-10-01  Dave MacLachlan  <dmaclach at gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
Add:
bug title
bug link
blank line
then your description.

> +        Gets rid of warnings on gcc about using anonymous namespaces 
> +          warning: 'StringKeyHashTraits' has a base
> +         'WTF::GenericHashTraits<<unnamed>::StringKey>' 
> +          whose type uses the anonymous namespace
> +	and

The spacing on this looks off. I think every in descriptions is indented beyond
this in the changelog.

> +          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
> +          WTF::HashTraits<PrivateIdentifier*> >' has a base
> +         'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
> +         PrivateIdentifier*> >' whose type uses the anonymous namespace
> +
> +        No tests required.
> +
> +        * bindings/v8/npruntime.cpp:
> +

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.