[Webkit-unassigned] [Bug 20081] [Qt] Add support for windowless NPAPI plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20081





--- Comment #36 from Simon Hausmann <hausmann at webkit.org>  2009-10-01 12:33:55 PDT ---
(From update of attachment 40422)
> +#include <QLabel>

I guess this isn't really needed ;-)

> +            XCopyArea(QX11Info::display(), backingStorePixmap->handle(), m_drawable.handle(), gc, 
> +                offset.x() + m_windowRect.x() + m_clipRect.x(), offset.y() + m_windowRect.y() + m_clipRect.y(), 

There's a trailing whitespace after the above two lines!!!

(OMG, I would've never thought I'd get that anal in a patch review ;-)

>      setCallingPlugin(true);
> -    bool accepted = m_plugin->pluginFuncs();
> +    bool accepted = m_plugin->pluginFuncs()->event(m_instance, &event);

This is my favourite part of the patch.

> +    const QX11Info *x11Info = 0;

Coding style :)


Regardless of my silly style picks this patch is a great piece of work!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.