[Webkit-unassigned] [Bug 29952] Move RedirectScheduler to its own file
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 1 10:47:55 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29952
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #40425|review? |review+
Flag| |
--- Comment #3 from Darin Adler <darin at apple.com> 2009-10-01 10:47:55 PDT ---
(From update of attachment 40425)
Normally in cases like this I start the new file with an svn copy of the large
file I am extracting it from.
I am disappointed we had to make so many FrameLoader internals public in order
to break this out! (But that was a comment on the earlier patch really, not
this one.)
> + void schedule(PassOwnPtr<ScheduledRedirection> redirection);
Should leave our argument here.
I think the RedirectScheduler is not well factored with respect to the frame
loader. It contains more of the logic than I would like that has nothing to do
with scheduling per se, which is why we end up exporting so many new functions
from FrameLoader.
But this is a noble effort, lets keep going and see where it leads.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list