[Webkit-unassigned] [Bug 29961] Position of "Close" button in docked mode doesn't match the position of window "Close" button in detached mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 1 09:06:17 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29961


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40447|review?                     |review-
               Flag|                            |




--- Comment #7 from Timothy Hatcher <timothy at hatcher.name>  2009-10-01 09:06:17 PDT ---
(From update of attachment 40447)

> +body.attached.platform-qt .toolbar-item[class*="close-"] {

It would be better and faster for the engine to write this as:

body.attached.platform-qt .toolbar-item.close-right, body.attached.platform-qt
.toolbar-item.close-left

Also more correct if we ever add somthing like "enclose-foo".

> +body[class*="platform-mac"] .toolbar-item.close-right { 

Should be: body.platform-mac .toolbar-item.close-right


> +body:not([class*="platform-mac"]) .toolbar-item.close-left { 

Should be: body:not(.platform-mac) .toolbar-item.close-left

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list