[Webkit-unassigned] [Bug 31737] Chromium WebKit API WebPageSerializer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31737


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #13 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-11-30 17:58:35 PST ---
Attachment 44049 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Done processing WebCore/platform/text/StringBuilder.cpp
WebKit/chromium/src/WebNodeList.cpp:35:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebNodeList.cpp:38:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebNodeList.cpp
Done processing WebKit/chromium/src/WebString.cpp
Done processing WebKit/chromium/public/WebPageSerializer.h
Done processing WebKit/chromium/src/AssertMatchingEnums.cpp
Done processing WebKit/chromium/src/WebFrameImpl.h
Done processing WebKit/chromium/public/WebElement.h
WebKit/chromium/src/WebPageSerializerImpl.h:40:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebPageSerializerImpl.h
WebKit/chromium/src/WebNode.cpp:41:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebNode.cpp
Done processing WebKit/chromium/src/WebElement.cpp
WebKit/chromium/src/WebPageSerializerImpl.cpp:92:  Alphabetical sorting
problem.  [build/include_order] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:96:  Alphabetical sorting
problem.  [build/include_order] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:201:  Boolean expressions that
span multiple lines should have their operators on the left side of the line
instead of the right side.  [whitespace/operators] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:235:  Use 0 instead of NULL. 
[readability/null] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:329:  An else should appear on
the same line as the preceding }  [whitespace/newline] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:401:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/src/WebPageSerializerImpl.cpp:401:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/chromium/src/WebPageSerializerImpl.cpp:442:  Use 0 instead of NULL. 
[readability/null] [4]
WebKit/chromium/src/WebPageSerializerImpl.cpp:473:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/src/WebPageSerializerImpl.cpp:473:  Use 0 instead of NULL. 
[readability/null] [5]
Done processing WebKit/chromium/src/WebPageSerializerImpl.cpp
Done processing WebKit/chromium/public/WebPageSerializerClient.h
WebKit/chromium/src/WebEntities.cpp:36:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebEntities.cpp:40:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebEntities.cpp:50:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebEntities.cpp:125:  One line control clauses should not
use braces.  [whitespace/braces] [4]
Done processing WebKit/chromium/src/WebEntities.cpp
Done processing WebKit/chromium/public/WebNodeCollection.h
WebKit/chromium/src/WebDocument.cpp:43:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebDocument.cpp
Done processing WebKit/chromium/public/WebNodeList.h
Done processing WebCore/platform/text/StringBuilder.h
Done processing WebKit/chromium/src/WebEntities.h
WebKit/chromium/src/WebPageSerializer.cpp:35:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/src/WebPageSerializer.cpp:42:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebPageSerializer.cpp
Done processing WebKit/chromium/src/DOMUtilitiesPrivate.cpp
Done processing WebKit/chromium/src/DOMUtilitiesPrivate.h
WebKit/chromium/public/WebDocument.h:54:  More than one command on the same
line  [whitespace/newline] [4]
Done processing WebKit/chromium/public/WebDocument.h
Done processing WebKit/chromium/src/WebFrameImpl.cpp
Done processing WebKit/chromium/public/WebNode.h
WebKit/chromium/public/WebFormElement.h:53:  More than one command on the same
line  [whitespace/newline] [4]
Done processing WebKit/chromium/public/WebFormElement.h
Done processing WebKit/chromium/public/WebFrame.h
Done processing WebKit/chromium/public/WebString.h
WebKit/chromium/src/WebNodeCollection.cpp:38:  Alphabetical sorting problem. 
[build/include_order] [4]
Done processing WebKit/chromium/src/WebNodeCollection.cpp
Total errors found: 24

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.