[Webkit-unassigned] [Bug 31723] CSS Counter Nesting still does not work according to the spec.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31723


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43740|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2009-11-30 10:47:16 PST ---
(From update of attachment 43740)
> +                        // We found a reset counter that is on a renderer that is a sibling of ours or a parent.
> +                        if (isReset && (currentRenderer->parent() == counterOwner->parent())) {

Formatting nit: We normally don't use parentheses in this common type of
expression, and later in this same function this patch does not.

> +                    // CurrentCounter, the counter at the EndSearchRenderer is not reset.

Missing comma after the word "EndSearchRenderer" in this comment.

> +                    if (!isReset || (currentRenderer->parent() != counterOwner->parent())) {

Formatting nit: We normally don't use parentheses in this common type of
expression, and later in this same function this patch does not.

> +                        // We are no longer interested in previous siblings of the currentRenderer or their children
> +                        // as counters they may have attached cannot be the previous sibling of the counter we are placing

Missing period here.

> +        // This function is designed so that the same test is not done twice in an iteration, except for this one
> +        // which may be done twice in some cases.

I think this design choice has made the function a little harder to read than
most with more repeated code than I would like to see.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.