[Webkit-unassigned] [Bug 31806] Make GIF decoder support down-sampling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31806





--- Comment #3 from Yong Li <yong.li.webkit at gmail.com>  2009-11-30 07:39:20 PST ---
(In reply to comment #2)
> I didn't look too closely at the patch, but I wonder if it could be simplified
> even further by making scaledRect() be available with or without this define
> (and have it simply map to rect() when there's no scaling).

I guess the point is trying not to affect the existing code. "scaledRect()"
looks a little weird when down-sampling is not enabled. If a reviewer says he
will r+ with that, I would definitely like to do this change.

> Similarly, a
> couple of the places where we run the same loop body over a different set of
> coordinates, maybe we could simply set a temp to different values in the two
> cases, instead of #ifdefing the loop body?

Actually that's what I have tried. But I really don't like checking the same
value inside a loop, although the compiler may be able to optimize it. Also the
code in that way is not neat, I have to put #if at both the beginning and the
end of the loop body. It looks worse than current patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.