[Webkit-unassigned] [Bug 31288] Add a function to show render tree for debugging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31288





--- Comment #5 from Shinichiro Hamaji <hamaji at chromium.org>  2009-11-30 00:42:02 PST ---
Thanks for the review! I really want to use this function for my debugging.

> I'm not sure what "outputted" is supposed to mean.  I guess it's
> printedCharacters?

Yes, and thanks for the comment, printedCharacters is definitely better naming.
I changed the name.

> Can it just default to 0, with = 0?

Unfortunately, gdb cannot handle default parameters. If we make it a default
parameter, we always need to pass 0 for RenderObject::showRenderObject when
debugging with GDB. That's why I created two overloaded functions.

Also, I've noticed we may call showRenderObject() for a NULL RenderObject while
we are debugging. I added NULL checks for this pointers. This looks a bit weird
to check if this pointer is NULL. If you don't like this, I may make
showRenderObject a global function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.