[Webkit-unassigned] [Bug 31961] [Qt][Symbian] Report SymbianOS in user agent string for Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31961


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43991|review?                     |review-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2009-11-29 15:53:41 PST ---
(From update of attachment 43991)
In principle I think this patch looks good, but there are a few style issues:

> +    // Placeholder for SubPlatfrom Version

from -> form

> +    "%4; ");
> +
> +// Platform Version

This should be indented 4 spaces

> +    QString osVer;
> +#ifdef Q_OS_SYMBIAN
> +    QSysInfo::SymbianVersion symbianVersion = QSysInfo::symbianVersion();
> +switch (symbianVersion) {

This line is also missing indentation.

> +  case QSysInfo::SV_9_2:
> +      osVer = "/9.2";
> +      break;
> +  case QSysInfo::SV_9_3:
> +      osVer = "/9.3";
> +      break;
> +  case QSysInfo::SV_9_4:
> +      osVer = "/9.4";
> +      break;
> +  default: 
> +      osVer = "Unknown";
> +    }
> +#else
> +    osVer = "";
> +#endif

I suggest to omit the #else block that assigns an empty string
to the string that is already a null string.

> +// SubPlatform Version

Indentation

> +    QString subPlatformVer;
> +#ifdef Q_OS_SYMBIAN
> +    QSysInfo::S60Version s60Version = QSysInfo::s60Version();
> +switch (s60Version) {

Indentation

> +  case QSysInfo::SV_S60_3_1:
> +      subPlatformVer = "/3.1";
> +      break;
> +  case QSysInfo::SV_S60_3_2:
> +      subPlatformVer = "/3.2";
> +      break;
> +  case QSysInfo::SV_S60_5_0:
> +      subPlatformVer = "/5.0";
> +      break;
> +  default: 
> +      subPlatformVer = " Unknown";
> +    }
> +#else
> +    subPlatformVer = "";
> +#endif

Same as above, the assignment is unnecessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.