[Webkit-unassigned] [Bug 31604] WebSocket server should write errors to a log file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31604


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43898|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-11-29 13:52:02 PST ---
(From update of attachment 43898)
Looks OK, but why are we coyping this code from elsewhere?  It should be
abstracted into a sub routine.

I see this in the file already:

1380        my $absTestResultsDirectory = File::Spec->rel2abs(glob
$testResultsDirectory);
1381        my $sslCertificate = "$testDirectory/http/conf/webkit-httpd.pem";
1382    
1383        mkpath $absTestResultsDirectory;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.