[Webkit-unassigned] [Bug 22250] PLATFORM(CAIRO) should be defined by WIN_CAIRO define

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22250


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43988|                            |review?
               Flag|                            |




--- Comment #2 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-11-28 19:14:39 PST ---
Created an attachment (id=43988)
 --> (https://bugs.webkit.org/attachment.cgi?id=43988)
proposed solution

Revision r45831 (http://trac.webkit.org/changeset/45831) - after this bug was
filed - essentially introduced a solution. WIN_CAIRO is defined by the build
system and can be used to detect the CAIRO build instead of the "blacklist"
approach currently used in Platform.h.

http://trac.webkit.org/changeset/45831 also defined WTF_PLATFORM_CAIRO in all
relevant config.h files (it is not needed in JavaScriptCore/config.h as
JavaScriptCore is not relying on the WTF_PLATFORM_CAIRO). The solution is to
simply remove this part from Platform.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.