[Webkit-unassigned] [Bug 31956] Move some build decisions from Qt build system into source files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31956





--- Comment #2 from Kevin Ollivier <kevino at theolliviers.com>  2009-11-28 16:58:37 PST ---
(In reply to comment #0)
> This patch a step towards a new way to handle porting #ifdefs - as it has been
> proposed by Maciej Stachowiak on webkit-dev.
> 
> > I know there is a potential compile time tradeoff, but in some ways  
> > it would be nicer if all build systems built the same set of files,  
> > and we ifdef'd the contents. That would put the policy decisions all  
> > in one place (the port header).
> 
> see https://lists.webkit.org/pipermail/webkit-dev/2009-May/007858.html.
> 
> There was not probably a consensus on all aspects of Maciej's proposal but I
> was hoping that there was enough of consensus to approve the direction of the
> following patch.

I like the general idea, as it would simplify the wx port's wscripts even more,
but the wx part of the patch is wrong. We are compiling ThreadingPthreads.cpp
on all platforms, not ThreadingNone.cpp. It should be safe to define
JSC_MULTIPLE_THREADS for wx too, I'm actually not sure how it was overlooked.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.