[Webkit-unassigned] [Bug 31939] style-queue should only process each patch once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 27 15:27:22 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31939


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43965|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-11-27 15:27:22 PST ---
(From update of attachment 43965)
.cached_scm was a name from a naiver time. :)  I think we shoudl just call it
._scm now.

I feel like PatchCollection hasn't quite figured out what it is yet. :(  Part
of me thinks we shoudl make somethign that works perfectly for hte style queue
and worry about abstracting it later, since I had to rip PatchCollection out of
commit-queue already. :(

Looks OK though.  I'd prefer we went with _scm and _statusbot though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list