[Webkit-unassigned] [Bug 31923] [bzt] Unit test download commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31923


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43938|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-11-27 08:23:15 PST ---
(From update of attachment 43938)
I don't understand why you're adding "return tool":
 43         return tool

Why?
232              bugs_to_patches[bug_id] = bugs_to_patches.get(bug_id,
[]).append(patch)
 234             bugs_to_patches[bug_id] = bugs_to_patches.get(bug_id, []) +
[patch]

Does .append() return none?  Was it not working before?

I'm not sure I understand:
 36     def _default_options(self):
either, but it's nice to list them all.

Why does MockBugzilla inherit from Mock?
 34 class MockBugzilla(Mock):

I'm not saying it shouldn't, just not sure what that adds.

I would think that we would make:
 35     patch1 = {
into an array eventually.  THen the fetch_attachment lookup is super-simple.

Is this gonna be a problem?
 93         self.checkout_root = os.getcwd()
Does it ever touch the disk?  Will it end up leaving turd files as a result of
the test, or fail if you run-webkit-tests from a non-scm directory?

Otherwise looks OK.  The return and .append change are at least un-explained. 
The return tool change might be "wrong".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.