[Webkit-unassigned] [Bug 28306] double-clicking a word inside <b> beside newline select two words

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28306





--- Comment #16 from MORITA Hajime <morrita at gmail.com>  2009-11-26 08:03:41 PST ---
Thank you for reviewing. 

I've investingated TextIterator, 
And now I feels that it's hard to make SimplifiedBackwardsTextIterator to
follow TextIterator way
because:

- text boundary detection need "real" whitespace inside RenderText object, 
  but TextIterator::emitCharacter() and
SimplifiedBackwardsTextIterator::emitCharacter()
  use fake character storage on TextIterator's instance, 
  which break boundary-to-offset computation, and
- Although TextIterator traverse InlineBox to precisely collect text on the
element,
  Doing such on SimplifiedBackwardsTextIterator would make it no longer
"simplified".

So I just lookup trailing whitespaces for each text node on
SimplifiedBackwardsTextIterator::handleTextNode(). 
It should be safe because now we inspect the string content to verify trailing
whitespaces.
(My old patch didn't see the string content. It was bad thing.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.