[Webkit-unassigned] [Bug 21554] Hovering the "src" attribute for an image should show the image dimensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21554


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43881|review?                     |review-
               Flag|                            |




--- Comment #15 from Pavel Feldman <pfeldman at chromium.org>  2009-11-26 00:45:15 PST ---
(From update of attachment 43881)
Thanks for addressing the comments. It now looks really good and clean. Test is
very good too. Couple of minot nits and re are ready to land:

img-tooltip.html should be called elements-img-tooltip (we try to group things
by panels)

> +    function createPropertiesMapThenCallback(propertiesPayload)
> +    {

Since the interaction between front-end and injected script is asynchronous,
node that you passed into getProperties might
be already deleted. You should be ready for that. 'propertiesPayload' will be
'false' in that case and you should pass it further
as undefined or []. You should then be able to handle missing properties when
generating tooltip.

> +
> +    var innerMapping = WebInspector.domAgent._idToDOMNode;
> +    for (var nodeId in innerMapping) {
> +        if (innerMapping[nodeId].nodeName === "IMG") {
> +            WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode(innerMapping[nodeId], callback);
> +            break;
> +        }
> +    }
> +}

Nit: You should do return in place of break and call
testController.notifyDone(); after the loop. This way when elements panel
breaks and has no IMG, you will not need to wait for timieout.

You probably need to store img inline in order not to wait for load event, but
you should make it more simple. I'll attach a white rectangle of the same size
to the bug. it is 80 times smaller.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.