[Webkit-unassigned] [Bug 31877] [v8] Do not check the thread when accessing DOMDataStore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 10:34:26 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31877


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43854|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-11-25 10:34:26 PST ---
(From update of attachment 43854)
> Index: WebCore/bindings/v8/V8DOMMap.cpp
...
> +namespace {
> +
> +static inline DOMDataStore& getDOMDataStore()
> +{
> +    ASSERT(WTF::isMainThread());  // As of now, we must be always on the main thread.
> +    return MainThreadDOMData::getCurrentMainThreadStore();
> +}
> +
> +}

nit: The anonymous namespace is redundant.  A static function already has
internal linkage.  I would just delete the anonymous namespace.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list