[Webkit-unassigned] [Bug 18282] WebKit crashes with deeply nested divs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 08:16:01 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=18282


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43803|review?                     |review-
               Flag|                            |




--- Comment #15 from Eric Seidel <eric at webkit.org>  2009-11-25 08:15:59 PST ---
(From update of attachment 43803)
Can't commit with "OOPS" in a ChangeLog.  The "Reviewed by" line will be fixed
by our landing scripts, but:
No new tests. (OOPS!)
will cause the commit to fail.

The parsing case could be made quick by caching the current level of the parse
tree.

I'm not sure I'm a big fan of this change, but I don't really know what to
suggest.

r- because the ChangeLog would cause the commit to fail.

Testing for this is easy.  There should be a test which validates that we can't
add below 400 items.  Obviously that test only makes sense if this feature is
enabled, and would probably be skipped on all platforms except whichever plans
to use this.

Speakign of which, what platform would use this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list