[Webkit-unassigned] [Bug 31831] [Android] The select elements do not reflect the actual choice the user makes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 08:01:50 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31831


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43846|review?                     |review+
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-11-25 08:01:50 PST ---
(From update of attachment 43846)
Thanks for cleaning up the old code!

r=me, except:

>  bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const RenderObject::PaintInfo& info, const IntRect& rect)
>  {
> -    if (obj->isMenuList())
> -        return paintCombo(obj, info, rect);
> +    if (obj->isListBox()) {
> +        paintCombo(obj, info, rect);

Can this be just an early return?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list