[Webkit-unassigned] [Bug 31841] Linux Chromium sends too many click events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31841


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43792|review?                     |review-
               Flag|                            |




--- Comment #5 from David Levin <levin at chromium.org>  2009-11-24 15:12:24 PST ---
(From update of attachment 43792)
r- for no layout test.
You can send clicks from within layout tests, so it seems like it would be
possible to add a layout test. As an absolutely last resort, there is always
WebKit/WebCore/manual-tests


> Index: WebKit/chromium/src/gtk/WebInputEventFactory.cpp
> +gint getDoubleClickTime() {

The brace needs to go on the next line.

> +    g_object_get(G_OBJECT(settings), "gtk-double-click-time", &doubleClickTime, NULL);

Use 0 instead of NULL.

> +    if (GDK_BUTTON_PRESS == event->type) {
> +        static int numClicks = 0;
> +        static GdkWindow* eventWindow = NULL;

Use 0 instead of NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.