[Webkit-unassigned] [Bug 31839] JSON.stringify performance on undefined is very poor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 24 12:10:53 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31839





--- Comment #3 from Oliver Hunt <oliver at apple.com>  2009-11-24 12:10:52 PST ---
(From update of attachment 43785)
> +        void truncate(int length) const { m_rep->len = length; }

I am concerned about this change -- i'm not convinced that it's safe (as rep's
may be shared).  What is the object structure that leads to us need to roll
back the string?

I'm also wondering if maybe it's worth just switching to Vector<UChar> while we
build the string, which will remove any data sharing issues we could hit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list