[Webkit-unassigned] [Bug 31809] [CRASH] Assertion on clicking a link

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31809





--- Comment #8 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-11-24 07:37:26 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Personally I find tests essential to understanding most patches. :)  So I would
> > have likely done exactly the same as Adam and r-'d this w/o a test.
> 
> Ok, ok. I was just upset that after r- people would not be looking at it while
> I was baking the test. I was sure that the code authors (cc-ed) would find this
> problem trivial. The patch I provided was a wild guess, I wanted to get
> feedback early to be able to produce a good fix.
> 
> Let me provide a broader context:
> - This is one of the top crashers in chromium land according to the dev channel
> stats
> - This is a WebKit bug, hence will affect all WebKit-based browsers
> - There is a clear, repeatable way of reproducing it, mentioned in the bug.

... and I encouraged him to post the fix right away, hoping there would be
feedback. I assumed peeps will see that this is a crasher and treat it
accordingly.

BTW, Can haz review please? I am not extremely familiar with these parts of the
code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.