[Webkit-unassigned] [Bug 31799] run-webkit-tests doesn't accept directories/files with --skipped=only parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31799





--- Comment #1 from Csaba Osztrogonac <ossy at webkit.org>  2009-11-23 02:22:14 PST ---
@@ -2106,7 +2116,13 @@ sub readSkippedFiles
                 if ($skipped && $skipped !~ /^#/) {
                     if ($skippedOnly) {
                         if (!&fileShouldBeIgnored($skipped)) {
-                            push(@ARGV, $skipped);
+                            if (!$path) {
+                                push(@ARGV, $skipped);
+                            } elsif ($skipped =~/^($path)/) {
+                                push(@ARGV, $skipped);
+                            } elsif ($path =~/^($skipped)/) {
+                                push(@ARGV, $path);
+                            }
                         } elsif ($verbose) {
                             print "    $skipped\n";
                         }

1st case: Original case, if you simple call "run-webkit-tests --skipped-only"

2nd case: If you call "run-webkit-tests --skipped=only SKIPPED_DIR" and there
is a SKIPPED_DIR/skipped_file on skiplist, then SKIPPED_DIR/skipped_file will
be pushed.

3rd case: If you call "run-webkit-tests --skippes=only dir1/dir2/dir3" and dir1
is on skiplist, then dir1/dir2/dir3 will be pushed.

+    # Remove duplicated tests
+    @testsToRun = keys %{{ map { $_ => 1 } @testsToRun }};

It is necessary if there are duplicated entries on skiplist.
(eg. dir1/dir2/dir3 and dir1/dir2) It won't affect --iterations and
--repeat-each parameters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.