[Webkit-unassigned] [Bug 23556] On RTL pages, horizontal scrollbar is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23556





--- Comment #17 from Jeremy Moskovich <playmobil at google.com>  2009-11-22 02:10:42 PST ---
(From update of attachment 43559)
I'm not a reviewer, but here are my comments.
Hyatt or Dan should probably give their opinion on whether there's a better
fix.

> Index: WebCore/ChangeLog
> ===================================================================
> +        // Update the minimal left position.
Can you add some more details and point to the bug URL from the comment.

> +        m_rtlMinChildPosition = min(chPos, m_rtlMinChildPosition);
ASSERT(m_rtlMinChildPosition <= 0);

> +    // Reset the minimal left position for RTL child elements before start layouting children.
// Reset before preforming child layout.
> +    m_rtlMinChildPosition = 0;

> +    // Override the RenderBox::marginLeft().
// Override RenderBox::marginLeft().

> Property changes on: LayoutTests/fast/text/international/rtl-unexpected-underflow.html
> ___________________________________________________________________
> Name: svn:executable
>    + *
Is this OK?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.