[Webkit-unassigned] [Bug 31683] JSC bindings for HasIndexGetter generates incorrect code (affects MediaList and CSSStyleDeclaration)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31683





--- Comment #5 from Darin Adler <darin at apple.com>  2009-11-20 15:43:08 PST ---
(From update of attachment 43621)
You say that these now return empty string according to "the spec". What spec?
Does this also match other browsers? Which other browsers did you test.

Changing behavior could cause compatibility with sites that have worked with
Safari, for example, for years, so we want to be sure this matches both the de
facto standard and specifications.

> -    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "CSSVariablesDeclaration" or $type eq "DOMTokenList";
> +    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "CSSVariablesDeclaration";

This change seems separate from the others. Or is there some relationship? Do
you have test cases for all the uses of DOMTokenList?

>      if (i >= length())
> -        return String();
> +        return "";

>      if (i >= m_properties.size())
> -       return String();
> +       return "";

>      if (index >= m_variableNames.size())
> -        return String();
> +        return "";

I only see two tests where the result is an empty string, so I'm not sure all
three of these changes are covered by tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.