[Webkit-unassigned] [Bug 31744] BuildQueue should check if the tree is currently buildable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31744





--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-11-20 14:34:26 PST ---
(In reply to comment #2)
> (From update of attachment 43612 [details])
> "clean" build is overloaded.  Not what you want.
>
> Probably just "build"

Fixed.

>  152         Command.__init__(self, "Updates working copy and does a clean
> build.", "tt", options)

Fixed.

>  790             self.run_bugzilla_tool(["clean-build", self.port.flag(),
> "--force-clean", "--quiet", "--ignore-builders"])
> 
> shouldn't need --ignore builders, no?  why would "build" ever look at builders?

Removed.  I'm inclined to solve the "looking at the builders too much" problem
in a separate patch.

> error is evil!
>  39 from modules.logging import error, log, tee

This actually an unrelated bug fix.

> There is already a --no-update flag elsewhere:
>  81             make_option("--no-update", action="store_false", dest="update",
> default=True, help="Do not update the working copy."),
> 
> perhaps we should just copy or move that one?

I copied the text.  I'll unify this soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.