[Webkit-unassigned] [Bug 30721] [GTK] DRT reports error in the wrong test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30721





--- Comment #7 from Alejandro G. Castro <alex at igalia.com>  2009-11-20 09:42:30 PST ---
(In reply to comment #6)
> (From update of attachment 41855 [details])
> Chromium recently had similar troubles.  I still think putting this in some
> nicely named function would make this much clearer.  As-is, if we ever need to
> modify the "test shut down" procedure, it's difficult to tell where it is or
> what all of the code should be moved were this ever to move again.  r- because
> I really think this needs to be put in a function with a nice name and called
> from this runTests() location.
> 
> sendPixelResultsEOF() or something even more descriptive?

Right, refactoring the patch now ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.