[Webkit-unassigned] [Bug 21288] Implement HTML5's sandbox attribute for iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 20 05:18:22 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=21288





--- Comment #56 from Patrik Persson <patrik.j.persson at ericsson.com>  2009-11-20 05:18:21 PST ---
(In reply to comment #51)
> (From update of attachment 43508 [details])
> >  bool ScriptController::isEnabled()
> >  {
> >      Settings* settings = m_frame->settings();
> > -    return m_frame->loader()->client()->allowJavaScript(settings && settings->isJavaScriptEnabled());
> > +    return m_frame->loader()->client()->allowJavaScript(settings && settings->isJavaScriptEnabled() && !m_frame->loader()->isSandboxed(SandboxScripts));
> >  }
> 
> Loose end for after this lands: ScriptController::isEnabled needs to be
> renamed. It already checked more than just whether JavaScript was enabled.
> Maybe canExecuteScripts is the right name.
> 
> > +    // FIXME: The HTML5 DOM spec states that this attribute can raise an
> > +    // INVALID_STATE_ERR exception on getting if the Document has no
> > +    // browsing context.
> 
> Loose end for after this lands: Test case showing the problem? Bug report for
> the problem?

I can file (at least) bug reports for these. However, if it's fine with you,
I'd prefer to do it after the patch lands. Otherwise, I'd have to refer to
either code we're about to change, or code in an uncommitted patch.

> >                   attribute [ConvertNullToNullString] DOMString cookie
> > -                     /*setter raises (DOMException)*/;
> > +                     setter raises (DOMException),
> > +                     getter raises (DOMException);
> 
> Loose end for after this lands: Bug report for the problem that just plain
> "raises" does not work. Should be easy to fix.

https://bugs.webkit.org/show_bug.cgi?id=31720

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list