[Webkit-unassigned] [Bug 31711] Fake drag example does not work properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31711


Alejandro G. Castro <alex at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43568|                            |review?
               Flag|                            |




--- Comment #1 from Alejandro G. Castro <alex at igalia.com>  2009-11-20 03:15:25 PST ---
Created an attachment (id=43568)
 --> (https://bugs.webkit.org/attachment.cgi?id=43568)
Patch proposed to fix the problem

This is the proposed solution, we had to modify the expected result of the fake
drag because the previous solution did not considered the first moveTo for the
selection which is the same problem. The patch sets m_beganSelectingText in the
EventHandler::handleMousePressEventSingleClick, which means we will use that
selection object as start, not the one created in the first movement. Could
someone knowing the code better than me check the modification, maybe I'm
missing a situation when we create that selection that we do not want to use
it.

I've run the editing tests and all of them have the same result, except the
fake drag but it was wrong before because we do not get all the selected text
from the click.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.