[Webkit-unassigned] [Bug 31704] [chromium] Add setCaretBlinkInterval API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31704


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43547|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-11-19 21:27:33 PST ---
(From update of attachment 43547)
> +++ b/WebKit/chromium/src/WebViewImpl.cpp
...
> +void WebViewImpl::setCaretBlinkInterval(double interval) {
> +#if PLATFORM(LINUX)
> +    reinterpret_cast<RenderThemeChromiumLinux*>(theme())->setCaretBlinkInterval(interval);
> +#endif
> +}

theme() actually returns a singleton, so mutating this singleton via
a WebView instance is a bit confusing since it would cause the value
to be changed for all WebView instances.

since this is Linux only, perhaps you should just create a linux specific
header file in public/linux that exposes a static setter for this propery.

-darin

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.